Fix tests to accommodate new PyTorch SobolEngine #674
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Updates test to fix failures caused by pytorch/pytorch#49710 Removes the comparison against specifc sample values to be more robust in the future (but retains the distributional tests) Reviewed By: danielrjiang Differential Revision: D26207258 fbshipit-source-id: 3838339d6674518385ee6cf37faa7f52dc3de9dc
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26207258 |
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 98 98
Lines 6589 6589
=========================================
Hits 6589 6589 Continue to review full report at Codecov.
|
|
This pull request has been merged in 2c78d5e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updates test to fix failures caused by pytorch/pytorch#49710
Removes the comparison against specifc sample values to be more robust in the
future (but retains the distributional tests)
Reviewed By: danielrjiang
Differential Revision: D26207258