Skip to content

Commit

Permalink
Revert "Upgrade cmake version to 3.22.1 to build triton (#1331)" (#1351)
Browse files Browse the repository at this point in the history
* Revert "Upgrade cmake version to 3.22.1 to build triton (#1331)"

This reverts commit 18c5017.

* Selective revert

* Get cmake from pip

* Use 3.18.2 from conda
  • Loading branch information
huydhn committed Mar 13, 2023
1 parent a754b40 commit 76416e9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
6 changes: 3 additions & 3 deletions common/install_conda.sh
Expand Up @@ -9,7 +9,7 @@ chmod +x Miniconda3-latest-Linux-x86_64.sh
bash ./Miniconda3-latest-Linux-x86_64.sh -b -p /opt/conda
rm Miniconda3-latest-Linux-x86_64.sh
export PATH=/opt/conda/bin:$PATH
# cmake-3.22.1 from conda, same as the one used by PyTorch CI. The system cmake
# is too old to build triton
conda install -y conda-build anaconda-client git ninja cmake=3.22.1
# The cmake version here needs to match with the minimum version of cmake
# supported by PyTorch (3.18). There is only 3.18.2 on anaconda
conda install -y conda-build anaconda-client git ninja cmake=3.18.2
conda remove -y --force patchelf
5 changes: 2 additions & 3 deletions manywheel/Dockerfile
Expand Up @@ -21,10 +21,9 @@ RUN wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm &
rpm -ivh epel-release-latest-7.noarch.rpm && \
rm -f epel-release-latest-7.noarch.rpm

# cmake-3.22.1 from pip, same as the one used by PyTorch CI. cmake-3.18.4 is
# too old to build triton now
# cmake-3.18.4 from pip
RUN yum install -y python3-pip && \
python3 -mpip install cmake==3.22.1 && \
python3 -mpip install cmake==3.18.4 && \
ln -s /usr/local/bin/cmake /usr/bin/cmake

RUN yum install -y autoconf aclocal automake make
Expand Down

0 comments on commit 76416e9

Please sign in to comment.