aarch64: cd: switch from libomp to libgomp #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is the pytorch PR to test this change in ci: pytorch/pytorch#124353 |
snadampal
force-pushed
the
openmp_update
branch
from
57ad1cd
to
77a7bfe
Compare
malfet
approved these changes
Apr 24, 2024
snadampal
force-pushed
the
openmp_update
branch
from
77a7bfe
to
075abc1
Compare
In the current version of the CD scripts, torch libraries are linked to llvm openmp because conda openblas-openmp is linked to it. To switch to gnu libgomp, we are building the openblas from sources instead of installing from conda.
snadampal
force-pushed
the
openmp_update
branch
from
075abc1
to
b616ae7
Compare
|
fixed lint errors. |
|
Looks like it broke nightly builds, because you are building OpenBLAS without LAPACK, will revert and try to fwd fix during the day |
malfet
added a commit
that referenced
this pull request
Apr 25, 2024
This reverts commit b57d3a8 as it broke nightly tests, becuase OpenBLAS is built without LAPACK.
malfet
pushed a commit
that referenced
this pull request
Apr 25, 2024
In the current version of the scripts, torch libraries are linked to llvm openmp becasue conda openblas-openmp is linked to it. to switch to gnu libgomp, we are building the openblas from sources instead of installing from conda. In essence it reverts #1462 fixes #1774 (cherry picked from commit b57d3a8)
|
I will update the OpenBLAS build for LAPACK |
|
I have raised this PR to fix the missing LAPACK issue along with switching to libgomp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of the scripts, torch libraries are linked to llvm openmp becasue conda openblas-openmp is linked to it. to switch to gnu libgomp, we are building the openblas from sources instead of installing from conda.
fixes##1774