Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows use mkl static lib (take 2) #1798

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Conversation

xuhancn
Copy link
Contributor

@xuhancn xuhancn commented Apr 24, 2024

resubmit #1790 with fix PR #1797.

From pytorch issue: pytorch/pytorch#124009 I found libtorch seems use shared mkl lib and missing some mkl dll files.

  1. Currently pytorch Linux already use static mkl lib.
  2. Windows can also support static mkl lib, I have validated as update build guide to use mkl-static. pytorch#116946

Tested in https://github.com/pytorch/pytorch/actions/runs/8836875904/job/24264643410

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a test PR against PyTorch/PyTorch

@xuhancn
Copy link
Contributor Author

xuhancn commented Apr 24, 2024

Triggerred test from the dummy PR: pytorch/pytorch#124853
From the result: https://github.com/pytorch/pytorch/actions/runs/8821164940/job/24216482475, I still do some work to enable mkl-static for pytorch Windows: pytorch/pytorch#124869

@xuhancn
Copy link
Contributor Author

xuhancn commented Apr 25, 2024

Triggerred test from the dummy PR: pytorch/pytorch#124853 From the result: https://github.com/pytorch/pytorch/actions/runs/8821164940/job/24216482475, I still do some work to enable mkl-static for pytorch Windows: pytorch/pytorch#124869

After pytorch/pytorch#124925 merged, the static mkl not support issue is gone.
Test job: https://github.com/pytorch/pytorch/actions/runs/8834373375/job/24255862902?pr=124853
image

@xuhancn
Copy link
Contributor Author

xuhancn commented Apr 25, 2024

@malfet malfet changed the title Xu win mkl static Windows use mkl static lib (take 2) Apr 25, 2024
@malfet malfet self-requested a review April 25, 2024 17:46
@xuhancn
Copy link
Contributor Author

xuhancn commented Apr 25, 2024

@malfet malfet merged commit eebc2f0 into pytorch:main Apr 26, 2024
2 checks passed
@xuhancn xuhancn deleted the xu_win_mkl_static branch April 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants