allow "mean" reduction for TracInCPFast, TracInCPFastRandProj #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D34802879 |
…h#913) Summary: Pull Request resolved: pytorch#913 This adds support for the "reduction" of the loss function used by `TracInCPFast` and `TracInCPFastRandProj` to be "mean", not just "sum" (as before). This is done by appropriate scaling in `_basic_computation_tracincp_fast`. This scaling could alternatively been handled in `_jacobian_loss_wrt_inputs`, if this is a better option, can do that instead. Tests are run for more parameters - basically if a reduction="sum" test was run, a reduction="mean" test is now added. Reviewed By: vivekmig Differential Revision: D34802879 fbshipit-source-id: 5b8bbd87e5c0b0a1423a2d2745ced7af533009fe
99warriors
force-pushed
the
export-D34802879
branch
from
4819d68
to
b2375f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34802879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This adds support for the "reduction" of the loss function used by
TracInCPFastandTracInCPFastRandProjto be "mean", not just "sum" (as before). This is done by appropriate scaling in_basic_computation_tracincp_fast. This scaling could alternatively been handled in_jacobian_loss_wrt_inputs, if this is a better option, can do that instead. Tests are run for more parameters - basically if a reduction="sum" test was run, a reduction="mean" test is now added.Reviewed By: vivekmig
Differential Revision: D34802879