This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Make Groups More Distinctive #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for pytorch-ci-hud ready! 🔨 Explore the source changes: 5082032 🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-ci-hud/deploys/61c33ba86386f800078bd727 😎 Browse the preview: https://deploy-preview-197--pytorch-ci-hud.netlify.app/ |
|
This is totally a nit but could we make the boxes a softer tone, like grey or something |
janeyx99
reviewed
Dec 20, 2021
src/utils/JobStatusUtils.js
Outdated
|
|
||
| export function is_infra_failure(result) { | ||
| return result === "infrastructure_fail"; | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93
This does some refactoring and abstracts out the cells into functional components. We also add a border around the group cells so that people can more easily distinguish them.