Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chipset enum name to include 'vendor_' #210

Merged
merged 1 commit into from Nov 30, 2023

Conversation

prashanthswami
Copy link
Collaborator

The original change that introduced this should have used a consistent prefix for all enum types, for consistency sake.

The original change that introduced this should have used a consistent
prefix for all enum types, for consistency sake.
@prashanthswami
Copy link
Collaborator Author

Review: @malfet

@malfet
Copy link
Contributor

malfet commented Nov 30, 2023

@prashanthswami can you please stop pinging me for reviews. This project at the moment needs a maintainer and I'm not sure I have a proper bandwith to be one (if I one, I should not have let original riscV change in without proper testing on my end, but I have not setup my riscv board yet)

@malfet malfet merged commit b8b29a1 into pytorch:main Nov 30, 2023
8 checks passed
@prashanthswami
Copy link
Collaborator Author

@malfet Understood - I apologize for the frequent review requests, I'll pause going forward. I'm trying to understand what the next steps are here though, is there a set of people looking for a new maintainer? Can I follow along somehow to be informed if a maintainer has been selected, or if I find someone who's interested, can they offer to help maintain this library through some process? (Is that the Pytorch discussion forums?)

@malfet
Copy link
Contributor

malfet commented Nov 30, 2023

@prashanthswami discussion forum or Slack (did you join) sounds like a good venue. And yes, volunteers sounds great, but I would like them to be a seasoned contributor

@prashanthswami
Copy link
Collaborator Author

Haven't gotten an invite yet, but did submit the form (and got confirmation the form was submitted), would you be able to help loop me in there? I'll ask around with some folks who've worked on this library internally to see if they can help provide support here.

@prashanthswami prashanthswami deleted the fix-enum-name branch January 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants