Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emphasize shutdown should be called for DataLoader2 at the end of loop #922

Closed
3 tasks done
ejguan opened this issue Dec 13, 2022 · 1 comment
Closed
3 tasks done

Emphasize shutdown should be called for DataLoader2 at the end of loop #922

ejguan opened this issue Dec 13, 2022 · 1 comment
Assignees
@ejguan
Milestone
0.6.0

Comments

@ejguan
Copy link
Contributor

ejguan commented Dec 13, 2022 •
edited

馃摎 The doc issue

When ReadingService is presented, it's better to call shutdown from DataLoader2 to properly clean up either distributed process group or persistent worker processes.

  • We should add a note regarding shutdown to DataLoader2.
  • We need to add a tutorial section for DataLoader2
  • Beyond documentation, we need to clean up our test cases to make sure shutdown is called as examples for our customers.

Suggest a potential alternative/fix

No response
@ejguan ejguan changed the title Emphasize shutdown is recommended to be called for DataLoader2 Emphasize shutdown should be called for DataLoader2 at the end of loop Dec 13, 2022
@ejguan ejguan self-assigned this Dec 13, 2022
@ejguan ejguan added this to the 0.6.0 milestone Jan 27, 2023
@ejguan ejguan mentioned this issue Jan 31, 2023
Closed
facebook-github-bot pushed a commit that referenced this issue Feb 1, 2023
@ejguan @facebook-github-bot
DataLoader2 tutorial (#980)
1d98097 
Summary:
Fixes #689 #959 #922

### Changes

- Add a section regarding determinism for ReadingService
- Add simple tutorial for DataLoader2
- Fix table rendering for dataloader.html

Example result can be found: https://ejguan.github.io/dataloader2.html

Pull Request resolved: #980

Reviewed By: NivekT

Differential Revision: D42903523

Pulled By: ejguan

fbshipit-source-id: 3d5093312953ac5fb5f247b6a65e161b4842bf8f
@ejguan
Copy link
Contributor Author

ejguan commented Feb 6, 2023

I think this issue has been resolved.

@ejguan ejguan closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejguan ejguan

Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@ejguan