Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start to graduate PrototypeMultiProcessingReadingService from "prototype mode" #932

Closed
ejguan opened this issue Dec 22, 2022 · 5 comments
Closed

Start to graduate PrototypeMultiProcessingReadingService from "prototype mode" #932

ejguan opened this issue Dec 22, 2022 · 5 comments
Milestone
0.6.0

Comments

@ejguan
Copy link
Contributor

ejguan commented Dec 22, 2022 

    unrelated: we should start to graduate it from "prototype mode" and starts find initial pioneering use case adoption~

Originally posted by @wenleix in #919 (comment)
@ejguan ejguan changed the title Sstart to graduate PrototypeMultiProcessingReadingService from "prototype mode" Start to graduate PrototypeMultiProcessingReadingService from "prototype mode" Dec 22, 2022
@ejguan
Copy link
Contributor Author

ejguan commented Dec 22, 2022

We should start to replace MultiprocessingReadingService by PrototypeMultiProcessingReadingService

@NivekT
Copy link
Contributor

NivekT commented Dec 22, 2022

Agree, and we need rigorously testing for this. Last I checked PrototypeMultiProcessingReadingService seems to behave correctly when things go right, but I worry that it doesn't necessarily clean up properly when an exception is raised.

@ejguan
Copy link
Contributor Author

ejguan commented Jan 3, 2023 •
edited

Forget to mention, currently PrototypeMultiProcessingReadingService has distributed code, the graduation is blocked by availability of SequentialRS to combine both PrototypeMultiProcessingReadingService and DistributedReadingService. Then, the distributed code from PrototypeMultiProcessingReadingService can be removed.

@ejguan ejguan added this to the 0.6.0 milestone Jan 27, 2023
@wenleix
Copy link
Contributor

wenleix commented Feb 3, 2023 •
edited

Forget to mention, currently PrototypeMultiProcessingReadingService has distributed code, the graduation is blocked by availability of SequentialRS to combine both PrototypeMultiProcessingReadingService and DistributedReadingService. Then, the distributed code from PrototypeMultiProcessingReadingService can be removed.

With #985, what's left to graduate Prototype? :)

@ejguan
Copy link
Contributor Author

ejguan commented Feb 4, 2023

With #985, what's left to graduate Prototype? :)

Nothing in my mind. We can start to change it next week.

ejguan added a commit to ejguan/data that referenced this issue Feb 13, 2023
@ejguan @facebook-github-bot
Officially graduate ProtypeMPRS to MPRS
6e24e08 
Summary:
Fixes: pytorch#932

- Convert all references from `ProtypeMPRS` to `MPRS`
- Remove usage of `MPRS`

Differential Revision: D43245136

fbshipit-source-id: 6f3d2db131ca6ff478a6958c9c8b1449db36d448
@ejguan ejguan mentioned this issue Feb 13, 2023
Closed
2 tasks
ejguan added a commit to ejguan/data that referenced this issue Feb 13, 2023
@ejguan @facebook-github-bot
Officially graduate ProtypeMPRS to MPRS (pytorch#1009)
f70b3ce 
Summary:
Pull Request resolved: pytorch#1009

Fixes: pytorch#932

- Convert all references from `ProtypeMPRS` to `MPRS`
- Remove usage of `MPRS`

Differential Revision: D43245136

fbshipit-source-id: eccfb9f31696a4f810a9f48dd5392e1802e0028a
ejguan added a commit to ejguan/data that referenced this issue Feb 14, 2023
@ejguan @facebook-github-bot
Officially graduate ProtypeMPRS to MPRS (pytorch#1009)
9707a13 
Summary:
Pull Request resolved: pytorch#1009

Fixes: pytorch#932

- Convert all references from `ProtypeMPRS` to `MPRS`
- Remove usage of `MPRS`

Reviewed By: wenleix, NivekT

Differential Revision: D43245136

fbshipit-source-id: 2195a7aae64b8ded5483f5b37383a4fa2d94f13e
facebook-github-bot pushed a commit to pytorch/tnt that referenced this issue Feb 14, 2023
@ejguan @facebook-github-bot
Officially graduate ProtypeMPRS to MPRS (#1009)
ad45d1a 
Summary:
X-link: pytorch/data#1009

Fixes: pytorch/data#932

- Convert all references from `ProtypeMPRS` to `MPRS`
- Remove usage of `MPRS`

Reviewed By: wenleix, NivekT

Differential Revision: D43245136

fbshipit-source-id: 1fd67f0e9d55a984209b8e58edecdb6070d919cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Officially graduate ProtypeMPRS to MPRS ejguan/data
3 participants
@wenleix @NivekT @ejguan