-
Notifications
You must be signed in to change notification settings - Fork 222
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Resolve
compiler_flags
to allow Mac build (#3478)
Summary: Pull Request resolved: #3478 ## `-Wglobal-constructors` In ET-Vulkan, we use global constructors without global destructors. Example: [`auto cls = VulkanBackend();`](https://github.com/pytorch/executorch/blob/3a253e96baa89e5a5434e91a236df63d54e0949e/backends/vulkan/runtime/VulkanBackend.cpp#L511-L513) ``` xplat/executorch/backends/vulkan/runtime/VulkanBackend.cpp:511:6: error: declaration requires a global destructor [-Werror,-Wglobal-constructors] auto cls = VulkanBackend(); ^ ``` On Mac, this results in a `-Wglobal-constructors` warning, which is disabled in this change. ## `-Wmissing-prototypes` ## `-Wshadow` Same as pytorch/pytorch#125361 Reviewed By: SS-JIA Differential Revision: D56860764 fbshipit-source-id: 5e598a3774c04e9f4b4911cc7cbda14dbe703fd8
- Loading branch information
1 parent
74538f8
commit 4bd45c3
Showing
2 changed files
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters