Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut dependencies and clean up Arm backend unit tester #2231

Closed
wants to merge 3 commits into from
Closed

Cut dependencies and clean up Arm backend unit tester #2231

wants to merge 3 commits into from

Conversation

freddan80
Copy link
Collaborator

No description provided.

@freddan80
Cut dependencies and clean up Arm backend unit tester
569b9d3 
Change-Id: I4c5581284bef03c4baf2c75dc5741aed9a3076ef
Signed-off-by: Fredrik Knutsson <fredrik.knutsson@arm.com>
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2231

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 88a5287 with merge base 0b6add8 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2024
@freddan80
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Mar 4, 2024
@freddan80
Copy link
Collaborator Author

@pytorchbot label 'ci/trunk'

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2024

Didn't find following labels among repository labels: ci/trunk

@freddan80
Copy link
Collaborator Author

@pytorchbot label 'ciflow/trunk'

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 4, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Mar 4, 2024
@robell robell requested a review from digantdesai March 5, 2024 17:43
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 5, 2024

Please seek CI approval before scheduling CIFlow labels

@pytorch-bot pytorch-bot bot removed the ciflow/trunk label Mar 5, 2024
@freddan80
Copy link
Collaborator Author

None of the CI issues are related to my changes. AFAIK.

@freddan80 freddan80 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk and removed partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Mar 7, 2024
@freddan80
Copy link
Collaborator Author

@digantdesai The CI fails aren't related to this PR. When I try to re-run the CI. the failing jobs are not triggered. How do I proceed?

digantdesai
digantdesai approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@freddan80
Arm backend: Fix quantization clip issue
cb57ca1 
Add quantization tolerance to Add BI unit tests

Change-Id: I4a7a7d532eb43f2fcf2590b05fb7ce77f6665e5f
Signed-off-by: Fredrik Knutsson <fredrik.knutsson@arm.com>
@mergennachin mergennachin self-requested a review March 7, 2024 18:12
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

Can you rebase please?

@freddan80
Copy link
Collaborator Author

Done. Failing CI jobs unrelated to this change.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@freddan80
Copy link
Collaborator Author

Is this stuck on something that I have missed?

@facebook-github-bot
Copy link
Contributor

@digantdesai merged this pull request in 70c5be3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai approved these changes

@mergennachin mergennachin mergennachin approved these changes

Assignees
No one assigned
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@freddan80 @facebook-github-bot @digantdesai @mergennachin @robell