Remove dependency from pytorch core as git submodule #3530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3530
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 4 Unrelated FailuresAs of commit 553c5aa with merge base 251aa74 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mergennachin
force-pushed
the
remove_dependency
branch
from
44da84c
to
e427c30
Compare
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In this diff, I am removing external third-party library called "gen-oplist-lib" altogether. There's no need for this library. Differential Revision: D57078472
|
This pull request was exported from Phabricator. Differential Revision: D57078775 |
mergennachin
added a commit
that referenced
this pull request
May 8, 2024
Summary: Pull Request resolved: #3530 Differential Revision: D57078775 Pulled By: mergennachin
mergennachin
force-pushed
the
remove_dependency
branch
from
e427c30
to
94b8b39
Compare
larryliu0820
reviewed
May 8, 2024
| @@ -78,16 +78,23 @@ def define_common_targets(is_fbcode = False): | |||
| ], | |||
| ) | |||
|
|
|||
Summary: Pull Request resolved: #3530 Differential Revision: D57078775 Pulled By: mergennachin
mergennachin
force-pushed
the
remove_dependency
branch
from
94b8b39
to
553c5aa
Compare
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
larryliu0820
approved these changes
May 8, 2024
mergennachin
added a commit
to mergennachin/executorch-1
that referenced
this pull request
May 8, 2024
Summary: Pull Request resolved: pytorch#3530 Differential Revision: D57078775 Pulled By: mergennachin
mergennachin
added a commit
to mergennachin/executorch-1
that referenced
this pull request
May 8, 2024
Summary: Pull Request resolved: pytorch#3530 Differential Revision: D57078775 Pulled By: mergennachin
|
@mergennachin merged this pull request in 0492eeb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.