Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhelpful error message: file: ../../lib/Importer/Caffe2ModelLoader.cpp line: 175 message: Can't find the model or network files. #2647

Closed
bertmaher opened this issue Apr 3, 2019 · 6 comments
Closed

Unhelpful error message: file: ../../lib/Importer/Caffe2ModelLoader.cpp line: 175 message: Can't find the model or network files. #2647

bertmaher opened this issue Apr 3, 2019 · 6 comments
Labels
good first issue

Comments

@bertmaher
Copy link
Contributor

Would be nice to print what model/network it is looking for. Also, are "model" and "network" different things here? Could we pick one word or the other?
@nadavrot
Copy link
Contributor

nadavrot commented Apr 3, 2019

Related to #2627. (I think)

@bertmaher
Copy link
Contributor Author

Yep! I just thought it'd be good to document some of the places where our error reporting needs love :-)

@rdzhabarov
Copy link
Contributor

@ZchiPitt should be easy and useful for future debugging.

@SameerAsal
Copy link
Contributor

Hi @bertmaher

the line number you are pointing to seems to be different now (it is not really printing anything).

Can you please update this issue?

@SameerAsal
Copy link
Contributor

I think it is 247 maybe?

@ZchiPitt ZchiPitt removed their assignment Jul 25, 2019
@bertmaher
Copy link
Contributor Author

I think it's in these places (both the C2 and ONNX importers do it):
https://github.com/pytorch/glow/search?q=%22can%27t+find+the+model%22&unscoped_q=%22can%27t+find+the+model%22

@SameerAsal SameerAsal mentioned this issue Jul 26, 2019
Closed
SameerAsal added a commit to SameerAsal/glow that referenced this issue Jul 26, 2019
@SameerAsal
Update error messages to be more descriptive
b1d6fd0 
  This fixes issue pytorch#2647

  Add the name of the network or model we are trying to load to the log
  messages we print at failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update error messages to be more descriptive SameerAsal/glow
5 participants
@SameerAsal @bertmaher @nadavrot @ZchiPitt @rdzhabarov