Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[easy] Put code for finding a SaveNode/output of PH in common place #2695

Closed
bertmaher opened this issue Apr 9, 2019 · 1 comment
Closed

[easy] Put code for finding a SaveNode/output of PH in common place #2695

bertmaher opened this issue Apr 9, 2019 · 1 comment
Labels
good first issue

Comments

@bertmaher
Copy link
Contributor

As per #2692 there's probably a couple places we have a routine like this. If we already have it in a common location we should use that instead of the method in that PR, otherwise we should factor it out and put it somewhere common.
@rdzhabarov
Copy link
Contributor

Fixed in https://github.com/pytorch/glow/blob/master/include/glow/Graph/Graph.h#L1095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickgg @bertmaher @rdzhabarov