Added new compileFunctions method #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t once Updated backends.md
gcatron
force-pushed
the
add_multi_compile
branch
from
73c1aa6
to
f4dff7d
Compare
|
Hey @gcatron could we have used a Module here instead of an array of functions? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added new compileFunctions method which takes an ArrayRef of functions and returns a vector of compiledFunctions. This allows the compile to reason over shared constants between functions. Also added a new unittest and updated backends.md
Testing: ninja test
Documentation: Updated backends.md
Related to #2045