[Backends] Change command line memory options to kilobytes #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfix71
force-pushed
the
fix_llvm_cl_opt_unsigned
branch
from
13e22ff
to
9a5b64f
Compare
jfix71
changed the title
There was a problem hiding this comment.
@jfix71 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
bertmaher
reviewed
May 22, 2019
jfix71
force-pushed
the
fix_llvm_cl_opt_unsigned
branch
from
9a5b64f
to
47c90df
Compare
There was a problem hiding this comment.
@jfix71 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@jfix71 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
bertmaher
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is broken because the
en2gr_cpu_partition_testtries to set the CPU memory on the command line, but it seems that command line parameters don't work withuint64_ton some platforms. I've hit this issue in the past, and I'm not sure why it's the case.