Fix AOT bundle CMake build and regression tests #3027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgg
force-pushed
the
aot-wip2
branch
2 times, most recently
from
00fad07
to
89eb25e
Compare
|
fixed portability of uint64_t printfs in bundle example code |
jfix71
approved these changes
May 31, 2019
|
We download what we're using for the bundles, not 100% sure why we need all models. My guess was because we ran run.sh but looks like we don't so maybe we can remove the model download? |
There was a problem hiding this comment.
@nickgg has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The AOT bundle examples had multiple makefiles, of which the CMake version did not work properly. This fixes the CMakeLists for the two bundle examples (plus the two extra quantized versions) and deletes the extra Makefile.
We did regression test the mnist bundle using the non-CMake makefile, but not resnet50 - I've modified the CI script to test both bundles using the CMakeList version.
Documentation: updated AOT.md to remove references to the Run*Bundle targets which never worked as described and I have removed.
fixes #3013
Test Plan: ran manually, waiting to see if it works in CI.