Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Support more JIT IR nodes to PyTorchModelLoader #3181

Closed
wants to merge 1 commit into from

Conversation

jackm321
Copy link
Contributor

@jackm321 jackm321 commented Jun 26, 2019

Summary:

  • Add support for loading Constant, add, sub, conv2d, and relu PyTorch JIT IR Nodes
  • Setup operator tests using PyTest and setuptools
  • Added proper cl flags handling to setup.py

Documentation:

  • doyxgen comments
  • Add a short getting started guide in pytorch.md

Test Plan:
python setup.py test

Screen Shot 2019-06-26 at 2 04 15 PM

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@zrphercule zrphercule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackm321 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@jackm321 merged this pull request in 408cd8d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants