[glow] Fixing CI issues after changes in psf/black formatting utility #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D35149268 |
khabinov
added a commit
to khabinov/glow
that referenced
this pull request
Mar 31, 2022
Summary: Pull Request resolved: pytorch#5929 Differential Revision: D35149268 fbshipit-source-id: 7f04225765111a6b8fe588495d4f7059bf72c549
khabinov
force-pushed
the
export-D35149268
branch
from
d6e2a85
to
8eebcab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35149268 |
khabinov
added a commit
to khabinov/glow
that referenced
this pull request
Mar 31, 2022
Summary: Pull Request resolved: pytorch#5929 Differential Revision: D35149268 fbshipit-source-id: 1e34db3826ad5e2ae9a7eb9b37bc43677e61f0e2
khabinov
force-pushed
the
export-D35149268
branch
from
8eebcab
to
db93025
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35149268 |
khabinov
added a commit
to khabinov/glow
that referenced
this pull request
Mar 31, 2022
Summary: Pull Request resolved: pytorch#5929 Differential Revision: D35149268 fbshipit-source-id: 0dce0045819fc28dd5491f1e4e3e02d0e01faf5c
khabinov
force-pushed
the
export-D35149268
branch
from
db93025
to
9657145
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35149268 |
khabinov
added a commit
to khabinov/glow
that referenced
this pull request
Mar 31, 2022
Summary: Pull Request resolved: pytorch#5929 Differential Revision: D35149268 fbshipit-source-id: ed184cea6b858eb63503111badd3574831dc20e3
khabinov
force-pushed
the
export-D35149268
branch
from
9657145
to
a7c1913
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35149268 |
khabinov
added a commit
to khabinov/glow
that referenced
this pull request
Mar 31, 2022
…ch#5929) Summary: Pull Request resolved: pytorch#5929 ## The problem Earlier this week `black` formatting utility got broken psf/black#2964. An example stack trace: ``` Traceback (most recent call last): File "/usr/local/lib/python3.9/runpy.py", line 197, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code exec(code, run_globals) File "/tmp/venv/lib/python3.9/site-packages/black/__main__.py", line 3, in <module> patched_main() File "/tmp/venv/lib/python3.9/site-packages/black/__init__.py", line 6606, in patched_main patch_click() File "/tmp/venv/lib/python3.9/site-packages/black/__init__.py", line 6595, in patch_click from click import _unicodefun # type: ignore ImportError: cannot import name '_unicodefun' from 'click' (/tmp/venv/lib/python3.9/site-packages/click/__init__.py) ``` Sample failed run https://app.circleci.com/pipelines/github/pytorch/glow/14399/workflows/db9175d4-6b03-4da1-8650-23001941a5a3/jobs/106452 ## The solution Seems that we have to update to version `22.3.0`. This change also required to upgrade some Python scripts from `python2` to `python3`. Differential Revision: D35149268 fbshipit-source-id: 88d7356bbf8eff316821e03e016515b863551b82
khabinov
force-pushed
the
export-D35149268
branch
from
a7c1913
to
42dcd42
Compare
|
This pull request was exported from Phabricator. Differential Revision: D35149268 |
khabinov
changed the title
…ch#5929) Summary: Pull Request resolved: pytorch#5929 ## The problem Earlier this week `black` formatting utility got broken psf/black#2964. An example stack trace: ``` Traceback (most recent call last): File "/usr/local/lib/python3.9/runpy.py", line 197, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/local/lib/python3.9/runpy.py", line 87, in _run_code exec(code, run_globals) File "/tmp/venv/lib/python3.9/site-packages/black/__main__.py", line 3, in <module> patched_main() File "/tmp/venv/lib/python3.9/site-packages/black/__init__.py", line 6606, in patched_main patch_click() File "/tmp/venv/lib/python3.9/site-packages/black/__init__.py", line 6595, in patch_click from click import _unicodefun # type: ignore ImportError: cannot import name '_unicodefun' from 'click' (/tmp/venv/lib/python3.9/site-packages/click/__init__.py) ``` Sample failed run https://app.circleci.com/pipelines/github/pytorch/glow/14399/workflows/db9175d4-6b03-4da1-8650-23001941a5a3/jobs/106452 ## The solution Seems that we have to update to version `22.3.0`. This change also required to upgrade some Python scripts from `python2` to `python3`. Reviewed By: hl475 Differential Revision: D35149268 fbshipit-source-id: e6a3af9ae8ff56d9e1e2209f3535744f0b19f33e
|
This pull request was exported from Phabricator. Differential Revision: D35149268 |
khabinov
force-pushed
the
export-D35149268
branch
from
42dcd42
to
1ecd79d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Earlier this week black formatting utility got broken psf/black#2964.
An example stack trace:
Sample failed run https://app.circleci.com/pipelines/github/pytorch/glow/14399/workflows/db9175d4-6b03-4da1-8650-23001941a5a3/jobs/106452
The solution
Seems that we have to update to version 22.3.0. This change also required to upgrade some Python scripts from python2 to python3.
Differential Revision: D35149268