-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hydra-configs-torchvision] Configs for MNIST datasets #24
Comments
@omry The PR for this will also give us a chance to think about how to logically structure managing 'two projects' - both torch and torchvision. |
Another question is whether torchvision should become a dependency. It will need to be at least for tests. |
We need to decide if we want to have a different config distribution (pip pacakge) or if we are good with putting all subprojects in the same artifact. Is torchvesion released with it's own versioning or is it tied to PyTorch's version? |
please note there is more than torchvision, i.e. torchaudio (that we are using in NeMo) and torchtext (that I don't really have experience)... |
Yap, all those projects have their own versioning. My proposition is to do it as optional package, with optional dependencies so one can install
here's how we did it in NeMo when it comes to requirements: |
Okay, so if we do go with different pip packages per target library we support we end up with:
I added some text to the google doc about versioning, let's discuss there. |
Source: https://github.com/pytorch/vision/blob/master/torchvision/datasets/mnist.py
Using configen, create a subset of the torchvision datasets for MNIST. Pair with tests.
These should be along the same lines as @tkornuta-nvidia prototype in NeMo:
https://github.com/NVIDIA/NeMo/blob/main-vis-res/nemo/collections/cv/datasets/configs.py
The text was updated successfully, but these errors were encountered: