Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

EpochOutputStore can optionally store the data to the state #1939

Closed
vfdev-5 opened this issue Apr 14, 2021 · 6 comments 路 Fixed by #1982
Closed

EpochOutputStore can optionally store the data to the state #1939

vfdev-5 opened this issue Apr 14, 2021 · 6 comments 路 Fixed by #1982
Assignees
Projects

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Apr 14, 2021

馃殌 Feature

The idea is to give an option to have the following:

eos = EpochOutputStore()

evaluator = create_supervised_evaluator(model, metrics)
eos.attach(evaluator, name="eval_data")

# Adding the name is equivalent to
# name = "eval_data"
# @evaluator.on(Events.EPOCH_COMPLETED, name)
# def store_data(engine, name):
#     setattr(engine.state, name, eos.data)

state = evaluator.run(data)
print(len(state.eval_data))

In addition, it would make sense to move it from contrib to core as well, keeping BC.

@vfdev-5 vfdev-5 added this to To do in 0.5.1 via automation Apr 14, 2021
@vfdev-5 vfdev-5 removed this from To do in 0.5.1 Apr 14, 2021
@vfdev-5 vfdev-5 added this to To do in 0.6.0 via automation Apr 14, 2021
@radekosmulski
Copy link
Contributor

Read the code of EpochOutputStore and I think I understand what this is about 馃檪 Maybe this is something I could work on after I finish #1919?

Could I please ask what BC stands for?

@ydcjeff
Copy link
Contributor

ydcjeff commented Apr 15, 2021

There is 2 meaning AFAIK
Here BC means Backward Compatibility
Another one is Breaking Change

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 15, 2021

Thanks Jeff!

@radekosmulski Yes, BC is backward compatibility and a PR breaking it is called "BC-breaking" as far as I know.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 26, 2021

@radekosmulski would you like to work on this issue ?

@radekosmulski
Copy link
Contributor

@vfdev-5 - would love to! Will read through the code today and either come here to ask questions if anything is unclear or will start working on a draft of the implementation 馃檪

@radekosmulski
Copy link
Contributor

I opened #1974 but it is probably quite basic, happy to implement any changes that might be needed 馃檪

This is only a draft - as a next step, will move it out of contrib keeping BC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.6.0
Done
Development

Successfully merging a pull request may close this issue.

3 participants