New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give an option to store EpochOutputStore
data on engine.state
#1974
Conversation
EpochOutputStore
data on engine.state
@radekosmulski Thank you ! Please check my suggestion. |
ignite/contrib/handlers/stores.py
Outdated
"""Attaching `reset` method at EPOCH_STARTED and | ||
`update` method at ITERATION_COMPLETED.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radekosmulski please also update the docstring here.
Let's also put .. versionchanged::
as it is explained here : https://github.com/pytorch/ignite/blob/master/CONTRIBUTING.md#writing-documentation
We can put 0.5.0 version.
@radekosmulski thanks for the PR, looks good, just a docstring update remains. If you would like to move this class into core in another PR, it is OK for me (maybe even prefered way to do that). |
I added the changes in two commits - one updates the docstrings, the other the example. I am not sure if the update to the example is needed? Generally, not sure if this is the right way to do it 🙂 Will move it out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @radekosmulski
Implements #1939
Description: When
EpochOutputStore
is attached and aname
is provided, atEPOCH_COMPLETED
engine.state.{name}
is set toeos.data
(in other words,eos.data
is stored onengine.state
).Check list: