Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pytorch version to 1.x.x in setup.py and in meta.yaml. #1016

Merged
merged 5 commits into from May 6, 2020
Merged

pin pytorch version to 1.x.x in setup.py and in meta.yaml. #1016

merged 5 commits into from May 6, 2020

Conversation

erip
Copy link
Contributor

@erip erip commented May 5, 2020

Fixes #897

Description: Pins the version to >=1.0, <2 in conda recipe and in setup.py.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 5, 2020

Shouldn't we run simple tests on those pytorch version: 1.0, 1.1, 1.2 etc ?

@erip
Copy link
Contributor Author

erip commented May 5, 2020

Yes, probably so. Do we want to only run integration tests?

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 5, 2020

I do not want to load more our CI with complete matrix of Python and Pytorch versions.
Something in the middle can be to check for a single Python version (e.g. 3.6), all previous pytorch version (1.0, 1.1, 1.2, 1.3, 1.4) and run them cron-based once per week or so (another github action). No smoke or distrib tests there only pytest -vvv tests/

@vfdev-5
Copy link
Collaborator

vfdev-5 commented May 5, 2020

But maybe we can leave it for another PR...

@erip
Copy link
Contributor Author

erip commented May 6, 2020

I added an action to run on Sundays - let me know what you think, @vfdev-5

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Thanks @erip !

@vfdev-5 vfdev-5 merged commit d745fb9 into pytorch:master May 6, 2020
@erip erip deleted the feature/pin-pytorch-version branch May 6, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyTorch dependency is lacking version constraint
2 participants