New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin pytorch version to 1.x.x in setup.py and in meta.yaml. #1016
Conversation
Shouldn't we run simple tests on those pytorch version: 1.0, 1.1, 1.2 etc ? |
Yes, probably so. Do we want to only run integration tests? |
I do not want to load more our CI with complete matrix of Python and Pytorch versions. |
But maybe we can leave it for another PR... |
…st all 1.x pytorch distributions.
I added an action to run on Sundays - let me know what you think, @vfdev-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! Thanks @erip !
Fixes #897
Description: Pins the version to >=1.0, <2 in conda recipe and in setup.py.
Check list: