Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dict in metrics results #1478

Merged
merged 4 commits into from Nov 26, 2020
Merged

Add dict in metrics results #1478

merged 4 commits into from Nov 26, 2020

Conversation

sdesrozis
Copy link
Contributor

Fixes #1476

Description:

As discussed, in case of metrics returning dict, in addition to flattened values, dict is added.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

ignite/metrics/metric.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sdesrozis
I left a nit comment

sdesrozis and others added 2 commits November 25, 2020 20:43
Co-authored-by: vfdev <vfdev.5@gmail.com>
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Nov 26, 2020

@sdesrozis tests are failing: https://github.com/pytorch/ignite/runs/1455446251
could you please fix them ?

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sdesrozis !

@vfdev-5 vfdev-5 merged commit 92ba4df into pytorch:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in metrics behaviour
2 participants