Fix #283, refactor create tbtt engine method #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thank you! |
|
@jasonkriss @alykhantejani I let you merge this if you are OK too |
|
LGTM! @alykhantejani I'll let you merge. |
alykhantejani
approved these changes
Oct 15, 2018
| from ignite._utils import convert_tensor, apply_to_tensor | ||
| from ignite.engine import Engine | ||
| from ignite._utils import apply_to_tensor | ||
| from ignite.engine import Engine, _prepare_batch |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283
Description: refactored
create_supervised_tbptt_trainermethod following #283.Removed completely
_prepare_tbptt_batch.Replaceconvert_tensorbyprepare_batch(line)prepare_batchon time chunks (the quantity used to compute gradients) rather that whole time series mini bactchprepare_batchfunction in the argumentsnon_blockingin the arguments@AntoinePrv please review the modifications.
Check list: