Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed parameter scheduler bug with
CosineAnnealingWarmRestarts
#2938Fixed parameter scheduler bug with
CosineAnnealingWarmRestarts
#2938Changes from 24 commits
bb5e244
f56b362
5801dd5
34e77e7
86e564f
2f75b92
fcb555c
ccef9c2
37a9102
178c420
1cef268
b2897a8
3f7dd99
aea674d
8c7cebc
01636e2
bdcbad4
8ca28fd
92af29b
45da45b
96cb1dc
4a72e07
ea8b803
83d22d9
6e02a0f
165ed36
5c9b99d
4445b02
971fc64
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 813 in ignite/handlers/param_scheduler.py
Codecov / codecov/patch
ignite/handlers/param_scheduler.py#L813
Check warning on line 826 in ignite/handlers/param_scheduler.py
Codecov / codecov/patch
ignite/handlers/param_scheduler.py#L822-L826
Check warning on line 828 in ignite/handlers/param_scheduler.py
Codecov / codecov/patch
ignite/handlers/param_scheduler.py#L828
Check warning on line 834 in ignite/handlers/param_scheduler.py
Codecov / codecov/patch
ignite/handlers/param_scheduler.py#L834
Check warning on line 837 in ignite/handlers/param_scheduler.py
Codecov / codecov/patch
ignite/handlers/param_scheduler.py#L837
Check warning on line 840 in ignite/handlers/param_scheduler.py
Codecov / codecov/patch
ignite/handlers/param_scheduler.py#L839-L840
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need this, beacuse of shifting lrs if warmup_end_value == None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, it would be better to register the same number of samples instead of slicing here, otherwise it is unclear ?