Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in native::_do_all_gather related to group #2947

Conversation

sadra-barikbin
Copy link
Collaborator

@sadra-barikbin sadra-barikbin commented May 17, 2023

-Fix a bug in native::_do_all_gather related to group
-Improve idist.all_gather docstring

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: distributed Distributed module label May 17, 2023
@sadra-barikbin sadra-barikbin mentioned this pull request May 17, 2023
3 tasks
@sadra-barikbin sadra-barikbin force-pushed the Feature-allgather-tensors-with-different-shapes-but-the-same-ndim branch from d156ac3 to eeda68b Compare June 16, 2023 15:20
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 16, 2023

@sadra-barikbin please update PR title and description to match the content

@sadra-barikbin sadra-barikbin changed the title Feature allgather tensors with different shapes but the same ndim Fix a bug in native::_do_all_gather related to group Jun 16, 2023
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sadra-barikbin !

@vfdev-5 vfdev-5 enabled auto-merge (squash) June 19, 2023 07:38
@vfdev-5 vfdev-5 merged commit ffed9f3 into pytorch:master Jun 19, 2023
15 of 18 checks passed
@sadra-barikbin sadra-barikbin deleted the Feature-allgather-tensors-with-different-shapes-but-the-same-ndim branch June 19, 2023 08:30
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jun 20, 2023

@sadra-barikbin this PR breaks compatibility with previous versions: https://github.com/pytorch/ignite/actions/runs/5317062760

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: distributed Distributed module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants