Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Discord PR extension workflow output #3046

Merged
merged 3 commits into from Aug 31, 2023
Merged

Fix Discord PR extension workflow output #3046

merged 3 commits into from Aug 31, 2023

Conversation

guptaaryan16
Copy link
Contributor

Fixes #3014

Description:
The PR is to fix the wrong output of the Discord PR workflow, which now requires a pull request number to be a triggered. Also the issue workflow can't be triggered now when PR is labelled. This will fix the output of the comments in this extension. This PR also serves as a fix for the #3009.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the ci CI label Aug 28, 2023
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Aug 29, 2023

@guptaaryan16 please check this job : https://github.com/pytorch/ignite/actions/runs/6012827576/job/16308950170?pr=3046

Run EndBug/discuss-on-discord@v1.1.0
Checking inputs...
Error: Error: Input required and not supplied: destination

@guptaaryan16 guptaaryan16 marked this pull request as draft August 30, 2023 08:51
@vfdev-5 vfdev-5 changed the base branch from master to fix-discord-pr August 31, 2023 07:58
@vfdev-5 vfdev-5 marked this pull request as ready for review August 31, 2023 07:58
@vfdev-5 vfdev-5 merged commit cc3e0a8 into pytorch:fix-discord-pr Aug 31, 2023
4 of 5 checks passed
@vfdev-5 vfdev-5 mentioned this pull request Aug 31, 2023
Merged
vfdev-5 added a commit that referenced this pull request Aug 31, 2023
@vfdev-5 @guptaaryan16
Fix Discord PR extension workflow output (#3046) (#3051)
e3c625a 
* Fix Discord PR extension workflow output

* Update variable in discord_pull_requests.yaml

Co-authored-by: Aryan Gupta <97878444+guptaaryan16@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 left review comments

Assignees
No one assigned
Labels
ci CI help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guptaaryan16 @vfdev-5