Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned pypi release commands between nightly and stable #3104

Merged
merged 1 commit into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/binaries-nightly-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
chmod +x ./conda.recipe/build_and_upload.sh
./conda.recipe/build_and_upload.sh

- name: Build and Publish PyPi binaries
- name: Build and Publish PyPI binaries
shell: bash -l {0}
run: |
# workaround to fix https://github.com/pytorch/ignite/issues/2373
Expand Down
16 changes: 4 additions & 12 deletions .github/workflows/stable-release-pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,15 @@ jobs:
run: |
conda install -y pytorch torchvision cpuonly -c pytorch
pip install -r requirements-dev.txt
pip install --upgrade --no-cache-dir twine
python setup.py install

- name: Build and Publish PyPI binaries
shell: bash -l {0}
run: |
# workaround to fix https://github.com/pytorch/ignite/issues/2373
pip uninstall -y twine pkginfo
pip install --upgrade --no-cache-dir twine 'pkginfo>=1.8.2'
python setup.py sdist bdist_wheel
twine --version
twine check dist/*
TWINE_USERNAME="${{ secrets.PYPI_USER }}" TWINE_PASSWORD="${{ secrets.PYPI_TOKEN }}" twine upload --verbose dist/*

# docker-build-publish:
# name: Trigger Build and Push Docker images to Docker Hub
# needs: build-publish
# runs-on: ubuntu-latest

# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-python@v4
# with:
# python-version: "3.10"