Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update citations to match the linked whitepaper #3127

Merged
merged 4 commits into from Nov 10, 2023
Merged

update citations to match the linked whitepaper #3127

merged 4 commits into from Nov 10, 2023

Conversation

djwadhwa
Copy link
Contributor

Description: There are a few inline documentation citations that are not correct. I have used the associated whitepaper links provided to update the citation (including author and year)

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added examples Examples module: metrics Metrics module labels Nov 10, 2023
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 10, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.

vfdev-5
vfdev-5 reviewed Nov 10, 2023
View reviewed changes
ignite/metrics/gan/fid.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 reviewed Nov 10, 2023
View reviewed changes
ignite/metrics/gan/fid.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 reviewed Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @djwadhwa , I left few comments to improve consistency in the info. Please address them

@djwadhwa
Copy link
Contributor Author

Thank you for pointing these out @vfdev-5! I have updated the documentation to align with the recommended changes.

vfdev-5
vfdev-5 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djwadhwa , lgtm!

@vfdev-5 vfdev-5 merged commit 30ceaf2 into pytorch:master Nov 10, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
examples Examples module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djwadhwa @vfdev-5