Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite test for Entropy metric #3216

Merged
merged 16 commits into from Mar 23, 2024
Merged

Rewrite test for Entropy metric #3216

merged 16 commits into from Mar 23, 2024

Conversation

kzkadc
Copy link
Contributor

@kzkadc kzkadc commented Mar 23, 2024

Fixes #3210 (comment)

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@kzkadc
Copy link
Contributor Author

kzkadc commented Mar 23, 2024

@vfdev-5 I updated the test for Entropy metric, but I'm not certain if it's correct.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 23, 2024

@kzkadc thanks a lot for the draft, I'll push the corrections to the PR directly and we can land it after that

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kzkadc !

@vfdev-5 vfdev-5 merged commit 2d3f42a into pytorch:master Mar 23, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants