Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 782: tqdm_logger did not account for epoch_length argument #785

Merged
merged 3 commits into from Feb 15, 2020
Merged

Fix Issue 782: tqdm_logger did not account for epoch_length argument #785

merged 3 commits into from Feb 15, 2020

Conversation

ykumards
Copy link
Contributor

@ykumards ykumards commented Feb 15, 2020 •
edited by vfdev-5

Fixes #782

Description: tqdm logger did not account for epoch_length arg in engine and displayed wrong epoch length

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@ykumards ykumards changed the title Issue 782 Fix Issue 782: tqdm_logger did not account for epoch_length argument Feb 15, 2020
vfdev-5
vfdev-5 approved these changes Feb 15, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Yogesh!

@vfdev-5 vfdev-5 merged commit 64b8d6f into pytorch:master Feb 15, 2020
@ykumards ykumards deleted the issue-782 branch February 15, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tqdm_logger does not take epoch_length into account
2 participants
@ykumards @vfdev-5