Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NeptuneSaver for logging model checkpoints #821

Merged
merged 28 commits into from Mar 9, 2020

Conversation

jakubczakon
Copy link
Contributor

Fixes #

  • Added NeptuneSaver for logging model checkpoints to neptune.
  • In all examples, I've added token for anonymous user neptuner to makes things easier for new-comers to see how it works.

Description:
NeptuneSaver can be used like DiskSaver

to_save = {'model': model}
handler = Checkpoint(to_save, NeptuneSaver(npt_logger), n_saved=2,
                     filename_prefix='best', score_function=score_function,
                     score_name="validation_accuracy",
                     global_step_transform=global_step_from_engine(trainer))
validation_evaluator.add_event_handler(Events.COMPLETED, handler)

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 2, 2020

@jakubczakon thanks for the PR, I let you fix failing tests and we are good, I think

@jakubczakon
Copy link
Contributor Author

@vfdev-5 thanks!
I may change/fix one more thing on neptune side.

@jakubczakon
Copy link
Contributor Author

jakubczakon commented Mar 7, 2020

@vfdev-5 ok, so I fixed tests and added the change I wanted in-line with the update on the neptune-client side.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Thanks Jakub!

@vfdev-5 vfdev-5 merged commit 3cd244f into pytorch:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants