Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 855 #859

Merged
merged 7 commits into from Mar 29, 2020
Merged

Issue 855 #859

merged 7 commits into from Mar 29, 2020

Conversation

ykumards
Copy link
Contributor

@ykumards ykumards commented Mar 29, 2020

Fixes #855

Description: When warmup_end_value is None, it is set to optimizer initial LR

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykumards Please, don't forget to apply black on sources :) I can't commit in your repo to do it.

LGTM :)

@ykumards
Copy link
Contributor Author

@ykumards Please, don't forget to apply black on sources :) I can't commit in your repo to do it.

LGTM :)

Oh, we had a hook for that right?

@sdesrozis
Copy link
Contributor

@ykumards Please, don't forget to apply black on sources :) I can't commit in your repo to do it.
LGTM :)

Oh, we had a hook for that right?

Oh maybe during merge because it missed something here. Btw, that's not really important and it was by pure chance that I saw that :)

@ykumards
Copy link
Contributor Author

@ykumards Please, don't forget to apply black on sources :) I can't commit in your repo to do it.
LGTM :)

Oh, we had a hook for that right?

Oh maybe during merge because it missed something here. Btw, that's not really important and it was by pure chance that I saw that :)

@sdesrozis You were right! Black formatting was off, thanks pointing it out :)

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yogesh!

@vfdev-5 vfdev-5 merged commit dec069e into pytorch:master Mar 29, 2020
@ykumards ykumards deleted the issue-855 branch March 30, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make optional warmup_end_value in create_lr_scheduler_with_warmup
3 participants