#902-Patch avoid moving model #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the model move - Update the docstring and include a warning note - Updated the tests to make sure the behavior is as expected.
Grepped the repo and made the required changes to keep everything in-line with the new changes to `create_supervised`. Hopefully I didn't miss anything. I did *not* rerun the FastaiLRFinder_MINST.ipynb. The output would change and add unnecessary size to the rep.
vfdev-5
reviewed
Apr 9, 2020
Minyus
added a commit
to Minyus/pipelinex
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
Description:
Grepped the repo and made the required changes to keep everything
in-line with the new changes to
create_supervised.Hopefully, I didn't miss anything.
I did not rerun the FastaiLRFinder_MINST.ipynb.
The output would change and add unnecessary size to the repo.
Check list: