Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NeptuneLogger improvements #951

Merged
merged 34 commits into from Apr 21, 2020
Merged

NeptuneLogger improvements #951

merged 34 commits into from Apr 21, 2020

Conversation

jakubczakon
Copy link
Contributor

@jakubczakon jakubczakon commented Apr 21, 2020 •
edited by vfdev-5

Fixes #946
Fixes #947
Fixes #948

Description:

  • fixed api_token=None
  • things can be logged without calling experiment -> npt_logger.log_metric(...)
  • fixed experiment_name naming bug

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

jakubczakon and others added 30 commits January 26, 2020 18:40
@jakubczakon
added output handlers, model checkpoint handler, added mnist example,…
0760506 
… added initial tests file
@jakubczakon
added exp link to examples, added tests
ea65a1a
@jakubczakon
added neptune do docs
9372b8b
@jakubczakon
Merge branch 'master' into master
f3d81c5
@jakubczakon
fixed test
c3d9556
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
bfff60c
@jakubczakon
fixed imports
741d3d7
@jakubczakon
added neptune-client to test dependencies
0d3b1f5
@jakubczakon
fixed missing package message
7f00f6a
@jakubczakon
Merge branch 'master' into master
cc5ca70
@jakubczakon
dropped model checkpoing handler
cc450b8
@jakubczakon
updated experiment link
b0bf959
@jakubczakon
dropped __futures__ print_function
73d4001
@jakubczakon
updated fork
e47a994
@jakubczakon
added NeptuneSaver and tests
d69068c
@actions-user
autopep8 fix
1cdfd83
@jakubczakon
updated token to anonymous user neptuner
39e2c66
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
de7000f
@jakubczakon
updated experiment link
5b345a6
@jakubczakon
Merge branch 'master' into master
b2e0901
@jakubczakon
updated token to 'ANONYMOUS'
7ddf4d3
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
6b13741
@jakubczakon
Merge branch 'master' into master
a0a43d9
@jakubczakon
updated examples, fixed tests
05d3c6f
@actions-user
autopep8 fix
4022987
@jakubczakon
fixed serializable test
d2a8b23
@jakubczakon
Merge branch 'master' of https://github.com/neptune-ai/ignite
fb59d0c
@jakubczakon
fixed serializable model test
2a79216
@jakubczakon
local
c2bc4c5
@jakubczakon
added __getattr__, fixed experiment_name, fixed api_token=None
d363722
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Apr 21, 2020

Maybe, we can keep self.experiment such that we can have both API available ?

@jakubczakon
Copy link
Contributor Author

Ok, I'll add it back.

@jakubczakon
Copy link
Contributor Author

I think this fail on 3.6, pytorch is not my fault :(.
Could you re-run this @vfdev-5 ?

vfdev-5
vfdev-5 approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jakubczakon !

@vfdev-5 vfdev-5 merged commit ca9d08e into pytorch:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jakubczakon @vfdev-5