Fix user_annotation event for dataloader and optimizer nodes #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Dataloader and Optimizer events are from record_function which saves as user annotations. Therefore check for these two cases when looking for dataloader and optimizer events. Otherwise the charts will be empty in tensorboard. Differential Revision: D42643341 Pulled By: aaronenyeshi fbshipit-source-id: 233875df1298cf5d385324887139ed9107901675
|
This pull request was exported from Phabricator. Differential Revision: D42643341 |
|
@aaronenyeshi merged this pull request in b0e331a. |
aaronenyeshi
added a commit
to aaronenyeshi/kineto
that referenced
this pull request
Feb 24, 2023
Summary: Update the version of the Tensorboard plugin package. This is to pick up a few patches to fix user annotation events in GPU summaries (pytorch#709), and Distributed view (pytorch#717). Differential Revision: D43578914 Pulled By: aaronenyeshi fbshipit-source-id: 5cdc90deade4d9c40178574e930c52bd98468770
This was referenced Feb 24, 2023
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
Summary: Pull Request resolved: #732 Update the version of the Tensorboard plugin package. This is to pick up a few patches to fix user annotation events in GPU summaries (#709), and Distributed view (#717). Test Plan: N/A Reviewed By: leitian Differential Revision: D43578914 Pulled By: aaronenyeshi fbshipit-source-id: ac4392863b42b99e78b4aaa19d01dc2652b89320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Dataloader and Optimizer events are from record_function which saves as user annotations. Therefore check for these two cases when looking for dataloader and optimizer events. Otherwise the charts will be empty in tensorboard.
Differential Revision: D42643341
Pulled By: aaronenyeshi