Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event_parser.py to detect ProfileRole.Communication with NCCL #763

Closed
wants to merge 2 commits into from
Closed

Fix event_parser.py to detect ProfileRole.Communication with NCCL #763

wants to merge 2 commits into from

Conversation

pbelevich
Copy link
Contributor

@pbelevich pbelevich commented May 27, 2023 •
edited
Loading

It's one of the reasons of missing Distributed View #640

@aaronenyeshi @mrshenli @kwen2501

@facebook-github-bot
Copy link
Contributor

Hi @pbelevich!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

aaronenyeshi
aaronenyeshi approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@aaronenyeshi
Copy link
Member

Please check the unit test failures in TB_Plugin_CI.

=========================== short test summary info ============================
FAILED test_profiler.py::TestDistributed::test_distributed_nccl - AssertionError: Lists differ: [105, 0, 0, 75, 0, 0, 20, 35, 235] != [105, 0, 0, 16, 0, 0, 79, 35, 235]

First differing element 3:
75
16

- [105, 0, 0, 75, 0, 0, 20, 35, 235]
?             ^^        ^^

+ [105, 0, 0, 16, 0, 0, 79, 35, 235]
?             ^^        ^^
=================== 1 failed, 33 passed, 7 skipped in 46.88s ===================

aaronenyeshi
aaronenyeshi approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

@aaronenyeshi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@aaronenyeshi merged this pull request in 82d9239.

aaronenyeshi added a commit to aaronenyeshi/kineto that referenced this pull request Jun 5, 2023
@aaronenyeshi @facebook-github-bot
Bump the TB Plugin Version 0.4.3
4b3eb5c 
Summary: Update the version of the Tensorboard plugin package. Pick up new patch for Distributed view (pytorch#763).

Differential Revision: D46444636

Pulled By: aaronenyeshi

fbshipit-source-id: 80f5f4927748cc1667890c150f4bb022137a858b
@aaronenyeshi aaronenyeshi mentioned this pull request Jun 5, 2023
Closed
facebook-github-bot pushed a commit that referenced this pull request Jun 5, 2023
@aaronenyeshi @facebook-github-bot
Bump the TB Plugin Version 0.4.3 (#764)
8aa6ffb 
Summary:
Pull Request resolved: #764

Update the version of the Tensorboard plugin package. Pick up new patch for Distributed view (#763).

Test Plan: CI

Reviewed By: xuzhao9

Differential Revision: D46444636

Pulled By: aaronenyeshi

fbshipit-source-id: 110785de8d5d3be73d55ad4c5783fce4b9d528ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbelevich @facebook-github-bot @aaronenyeshi