Skip to content

Commit

Permalink
Update on "Make CI error on inductor fallback when decomp is available"
Browse files Browse the repository at this point in the history
Fixes #99446 

Remove the warning, as that annoyed end-users who don't know what to do about it.

Instead, try to hold the line by preventing any decomp from being added without making
the corresponding change to inductor's fallbacks.

Note: we probably still need to better document how to update inductor's decomps,
for now it's pretty much "go ask the inductor team for advice"

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
  • Loading branch information
wconstab committed Apr 19, 2023
2 parents 5ef5711 + b61af25 commit 00566c1
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion torch/_dynamo/allowed_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ def _is_allowed_module_prefix(obj):
"torch._C.inductor.",
"torch.fx.",
"torch.distributed.fsdp.",
"torch.distributed.nn.functional",
)
allowed_modules_dot = tuple([x + "." for x in allowed_modules])
module = inspect.getmodule(obj)
Expand Down

0 comments on commit 00566c1

Please sign in to comment.