Skip to content

Commit

Permalink
[NCCL][Test Only] no change
Browse files Browse the repository at this point in the history
Differential Revision: [D23922690](https://our.internmc.facebook.com/intern/diff/D23922690/)

ghstack-source-id: 112873717
Pull Request resolved: #45320
  • Loading branch information
mingzhe0908 committed Sep 25, 2020
1 parent 02d8906 commit 0689120
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions torch/lib/c10d/NCCLUtils.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#define ENABLE_NCCL_ERROR_CHECKING
#endif

// Fix build issues with NCCL P2P - until then disable NCCL send/recv.
#if defined(ENABLE_NCCL_A2A) && (ENABLE_NCCL_A2A == 1)
// P2P is enabled only for NCCL versions 2.7+ since ncclSend()
// and ncclRecv() are not supported in earlier versions.
#if defined(NCCL_MAJOR) && (NCCL_MAJOR == 2) && defined(NCCL_MINOR) && \
Expand All @@ -25,6 +27,7 @@
#elif defined(NCCL_MAJOR) && (NCCL_MAJOR >= 3)
#define ENABLE_NCCL_P2P_SUPPORT
#endif
#endif

// Macro to throw on a non-successful NCCL return value.
#define C10D_NCCL_CHECK(cmd) \
Expand Down
1 change: 1 addition & 0 deletions torch/lib/c10d/ProcessGroupNCCL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ ncclResult_t ncclAlltoallv(
ncclDataType_t type,
ncclComm_t comm,
cudaStream_t stream) {
std::cout << "ncclAlltoallv?" << std::endl;
int numranks;
C10D_NCCL_CHECK(ncclCommCount(comm, &numranks));
C10D_NCCL_CHECK(ncclGroupStart());
Expand Down

0 comments on commit 0689120

Please sign in to comment.