fix empty annotated list

pytorch · Nov 5, 2020 · 213fcc5 · 213fcc5
1 parent 99a53db
commit 213fcc5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/test/jit/test_list_dict.py b/test/jit/test_list_dict.py
@@ -147,7 +147,7 @@ def foo3():
             return list(list("abc"))
 
         self.checkScript(foo3, ())
-        FileCheck.check_count("aten::list", 2, exactly=True)
+        FileCheck().check_count("aten::list", 2, exactly=True).run(torch.jit.script(foo3).graph)
 
     def test_min_bool_list(self):
         def jit_min_list(a, b):

diff --git a/torch/csrc/jit/frontend/ir_emitter.cpp b/torch/csrc/jit/frontend/ir_emitter.cpp
@@ -2899,7 +2899,12 @@ struct to_ir {
       case prim::list: {
         if (apply.inputs().size() == 0) {
           TypePtr type = type_hint ? type_hint : ListType::ofTensors();
-          return std::make_shared<SimpleValue>(graph->insertNode(graph->createList(type, {}))->output());
+          if (!type->cast<ListType>()) {
+            throw ErrorReport(apply.range())
+            << "Expected list type annotation for list(), found "
+            << type_hint->repr_str();
+          }
+          return std::make_shared<SimpleValue>(graph->insertNode(graph->createList(type->expect<ListType>()->getElementType(), {}))->output());
         }
         // list(iter) desugars to [_elem for _elem in iter]
         checkApplyNumInputs(apply, 1);