Skip to content

Commit

Permalink
Update on "[ONNX] Register list/tuple/dict to format_argumment and re…
Browse files Browse the repository at this point in the history
…factor fx.Node format_argument in diagnostics"


Previous to this PR, the SARIF reports don't have detail on torch.fx.Node (shape/dtype), and don't unpack the tuple/list/dict. This PR provides thorough information of args/kwargs from torch in fx.graph expression: f32[64, 64, 2] (dtype[shape]).

Need microsoft/onnxscript#890

![dispatcher_sarif](https://github.com/pytorch/pytorch/assets/18010845/2567fac6-4154-4ce8-bc34-83950ef1c1d7)


[ghstack-poisoned]
  • Loading branch information
titaiwangms committed Jul 22, 2023
2 parents 683c5c7 + 3f0df94 commit 2d6fe3b
Show file tree
Hide file tree
Showing 504 changed files with 7,153 additions and 4,708 deletions.
2 changes: 1 addition & 1 deletion .ci/docker/common/install_onnx.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ pip_install \
transformers==4.25.1

# TODO: change this when onnx-script is on testPypi
pip_install "onnxscript@git+https://github.com/microsoft/onnxscript@ab54cb17feb256ca52fa4c616e27e06b3ce67139"
pip_install "onnxscript@git+https://github.com/microsoft/onnxscript@b2c19a7b59e8b2dbdf531000845d721d131277c8"

# Cache the transformers model to be used later by ONNX tests. We need to run the transformers
# package to download the model. By default, the model is cached at ~/.cache/huggingface/hub/
Expand Down
2 changes: 1 addition & 1 deletion .ci/docker/requirements-ci.txt
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ xdoctest==1.1.0
#Pinned versions: 1.1.0
#test that import:

pygments==2.12.0
pygments==2.15.0
#Description: support doctest highlighting
#Pinned versions: 2.12.0
#test that import: the doctests
Expand Down
9 changes: 3 additions & 6 deletions .ci/pytorch/python_doc_push_script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ pushd docs

# Build the docs
if [ "$is_main_doc" = true ]; then
if ! build_docs html; then
exit $?
fi
build_docs html || exit $?

make coverage
# Now we have the coverage report, we need to make sure it is empty.
# Count the number of lines in the file and turn that number into a variable
Expand All @@ -110,9 +109,7 @@ if [ "$is_main_doc" = true ]; then
fi
else
# skip coverage, format for stable or tags
if ! build_docs html-stable; then
exit $?
fi
build_docs html-stable || exit $?
fi

# Move them into the docs repo
Expand Down
5 changes: 5 additions & 0 deletions .ci/pytorch/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,11 @@ test_perf_for_dashboard() {
"${target_flag[@]}" --"$mode" --"$dtype" --backend "$backend" --disable-cudagraphs --cpp-wrapper "$@" \
--output "$TEST_REPORTS_DIR/${backend}_cpp_wrapper_${suite}_${dtype}_${mode}_cuda_${target}.csv"
fi
if [[ "$DASHBOARD_TAG" == *freezing_cudagraphs-true* ]] && [[ "$mode" == "inference" ]]; then
python "benchmarks/dynamo/$suite.py" \
"${target_flag[@]}" --"$mode" --"$dtype" --backend "$backend" "$@" --freezing \
--output "$TEST_REPORTS_DIR/${backend}_with_cudagraphs_freezing_${suite}_${dtype}_${mode}_cuda_${target}.csv"
fi
if [[ "$DASHBOARD_TAG" == *aotinductor-true* ]] && [[ "$mode" == "inference" ]]; then
python "benchmarks/dynamo/$suite.py" \
"${target_flag[@]}" --"$mode" --"$dtype" --export-aot-inductor --disable-cudagraphs "$@" \
Expand Down
105 changes: 0 additions & 105 deletions .circleci/scripts/cpp_doc_push_script.sh

This file was deleted.

150 changes: 0 additions & 150 deletions .circleci/scripts/python_doc_push_script.sh

This file was deleted.

0 comments on commit 2d6fe3b

Please sign in to comment.