Skip to content

Commit

Permalink
Update on "Use object identity for deepcopy memo"
Browse files Browse the repository at this point in the history
Copy of #126089, with some fixes & tests (TODO)

[TODO description]

Differential Revision: [D57340612](https://our.internmc.facebook.com/intern/diff/D57340612)

[ghstack-poisoned]
  • Loading branch information
davidberard98 committed May 14, 2024
1 parent 2326b7d commit 31db7c0
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions test/cpp/api/ivalue.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,14 @@ TEST(IValueTest, DeepcopyTensors) {
// NOTE: this is actually incorrect. Ideally, these _should_ be aliases.
ASSERT_FALSE(copied_list[0].get().isAliasOf(copied_list[2].get()));

ASSERT_TRUE(copied_list[0].get().toTensor().allclose(tensor_list[0].get().toTensor()));
ASSERT_TRUE(copied_list[1].get().toTensor().allclose(tensor_list[1].get().toTensor()));
ASSERT_TRUE(copied_list[2].get().toTensor().allclose(tensor_list[2].get().toTensor()));
ASSERT_TRUE(copied_list[3].get().toTensor().allclose(tensor_list[3].get().toTensor()));
ASSERT_TRUE(copied_list[4].get().toTensor().allclose(tensor_list[4].get().toTensor()));
ASSERT_TRUE(copied_list[0].get().toTensor().allclose(
tensor_list[0].get().toTensor()));
ASSERT_TRUE(copied_list[1].get().toTensor().allclose(
tensor_list[1].get().toTensor()));
ASSERT_TRUE(copied_list[2].get().toTensor().allclose(
tensor_list[2].get().toTensor()));
ASSERT_TRUE(copied_list[3].get().toTensor().allclose(
tensor_list[3].get().toTensor()));
ASSERT_TRUE(copied_list[4].get().toTensor().allclose(
tensor_list[4].get().toTensor()));
}

0 comments on commit 31db7c0

Please sign in to comment.