Update on "[pytorch] Add triplet margin loss with custom distance"

Summary: As discussed [here](#43342),
adding in a Python-only implementation of the triplet-margin loss that takes a
custom distance function.  Still discussing whether this is necessary to add to
PyTorch Core.

Test Plan: python test/run_tests.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D23363898](https://our.internmc.facebook.com/intern/diff/D23363898)

[ghstack-poisoned]

.circleci/cimodel/data/binary_build_data.py

@@ -51,13 +51,16 @@ def get_processor_arch_name(cuda_version):
         ],
     )),
     # Skip CUDA-9.2 builds on Windows
-    windows=([v for v in dimensions.CUDA_VERSIONS if v != '92'], OrderedDict(
-        wheel=dimensions.STANDARD_PYTHON_VERSIONS,
-        conda=dimensions.STANDARD_PYTHON_VERSIONS,
-        libtorch=[
-            "3.7",
-        ],
-    )),
+    windows=(
+        [v for v in dimensions.CUDA_VERSIONS if v not in ['92', '110']],
+        OrderedDict(
+            wheel=dimensions.STANDARD_PYTHON_VERSIONS,
+            conda=dimensions.STANDARD_PYTHON_VERSIONS,
+            libtorch=[
+                "3.7",
+            ],
+        )
+    ),
 )
 
 # GCC config variants:

.circleci/cimodel/data/dimensions.py

@@ -5,6 +5,7 @@
     "92",
     "101",
     "102",
+    "110"
 ]
 
 STANDARD_PYTHON_VERSIONS = [

.circleci/cimodel/data/pytorch_build_data.py

@@ -5,13 +5,15 @@
     ("xenial", [
         ("rocm", [
             ("3.5.1", [
-                X("3.6"),
+                ("3.6", [
+                    ('build_only', [XImportant(True)]),
+                ]),
             ]),
         ]),
         ("gcc", [
             ("5.4", [  # All this subtree rebases to master and then build
-                XImportant("3.6"),
                 ("3.6", [
+                    ("important", [X(True)]),
                     ("parallel_tbb", [X(True)]),
                     ("parallel_native", [X(True)]),
                 ]),
@@ -69,7 +71,11 @@
             ]),
         ]),
         ("gcc", [
-            ("9", [XImportant("3.8")]),
+            ("9", [
+                ("3.8", [
+                    ("coverage", [XImportant(True)]),
+                ]),
+            ]),
         ]),
     ]),
 ]
@@ -145,7 +151,8 @@ def child_constructor(self):
             "libtorch": LibTorchConfigNode,
             "important": ImportantConfigNode,
             "build_only": BuildOnlyConfigNode,
-            "cuda_gcc_override": CudaGccOverrideConfigNode
+            "cuda_gcc_override": CudaGccOverrideConfigNode,
+            "coverage": CoverageConfigNode,
         }
         return next_nodes[experimental_feature]
 
@@ -232,6 +239,15 @@ def child_constructor(self):
         return ExperimentalFeatureConfigNode
 
 
+class CoverageConfigNode(TreeConfigNode):
+
+    def init2(self, node_name):
+        self.props["is_coverage"] = node_name
+
+    def child_constructor(self):
+        return ExperimentalFeatureConfigNode
+
+
 class ImportantConfigNode(TreeConfigNode):
     def modify_label(self, label):
         return "IMPORTANT=" + str(label)

.circleci/cimodel/data/pytorch_build_definitions.py

@@ -306,8 +306,12 @@ def instantiate_configs():
         is_important = fc.find_prop("is_important") or False
         parallel_backend = fc.find_prop("parallel_backend") or None
         build_only = fc.find_prop("build_only") or False
-        if build_only and restrict_phases is None:
+        is_coverage = fc.find_prop("is_coverage") or False
+        if build_only:
             restrict_phases = ["build"]
+        if is_coverage and restrict_phases is None:
+            restrict_phases = ["build", "coverage_test"]
+
 
         gpu_resource = None
         if cuda_version and cuda_version != "10":

.circleci/cimodel/data/simple/docker_definitions.py

@@ -28,6 +28,7 @@
     "pytorch-linux-xenial-py3.6-gcc7",
     "pytorch-linux-xenial-rocm3.3-py3.6",
     "pytorch-linux-xenial-rocm3.5.1-py3.6",
+    "pytorch-linux-bionic-rocm3.7-py3.6",
 ]
 
 

.circleci/cimodel/data/simple/mobile_definitions.py

@@ -57,11 +57,6 @@ def gen_tree(self):
         [DOCKER_REQUIREMENT_ASAN],
         ["build"]
     ),
-    MobileJob(
-        DOCKER_IMAGE_ASAN,
-        [DOCKER_REQUIREMENT_ASAN],
-        ["custom", "build", "static"]
-    ),
 
     # Use LLVM-DEV toolchain in android-ndk-r19c docker image
     MobileJob(