Skip to content

Commit

Permalink
Remove default timeout from PGNCCL::Options ctor (#112555)
Browse files Browse the repository at this point in the history
Providing this timeout to the Options ctor is overriding user-provided
values in cases where is_high_priority_stream is set.
Pull Request resolved: #112555
Approved by: https://github.com/fduwjj, https://github.com/H-Huang
  • Loading branch information
wconstab authored and pytorchmergebot committed Nov 2, 2023
1 parent a1ab22b commit 85e9363
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1898,7 +1898,7 @@ void ProcessGroupNCCL::workEnqueue(
}

ProcessGroupNCCL::Options::Options(bool is_high_priority_stream)
: Backend::Options(NCCL_BACKEND_NAME, kProcessGroupNCCLDefaultTimeout),
: Backend::Options(NCCL_BACKEND_NAME),
is_high_priority_stream(is_high_priority_stream) {}

static constexpr int CoalActive = 0x01, CoalColl = 0x02, CoalP2P = 0x04;
Expand Down

1 comment on commit 85e9363

@pytorchmergebot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted #112555 on behalf of https://github.com/wconstab due to This PR is wrong, see above explanation (comment)

Please sign in to comment.