Skip to content

Commit

Permalink
Make breakpad depdendencies private (#61183)
Browse files Browse the repository at this point in the history
Summary:
Otherwise, it will results in the following errors for people developing extensions
```
CMake Error in frontends/pytorch/csrc/CMakeLists.txt:
  Imported target "torch" includes non-existent path

    "/usr/local/include/breakpad"
```

Fixes different issue reported in #60485

Pull Request resolved: #61183

Reviewed By: driazati

Differential Revision: D29538332

Pulled By: malfet

fbshipit-source-id: e83cfd0b335e9b0b1ba5715789b09765db671346
  • Loading branch information
malfet authored and facebook-github-bot committed Jul 6, 2021
1 parent 635d864 commit 95cada8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions caffe2/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -999,9 +999,9 @@ if(LINUX)
find_path(BREAKPAD_INCLUDE_DIR breakpad)
if(BREAKPAD_LIB AND BREAKPAD_INCLUDE_DIR)
message(STATUS "found breakpad library")
target_link_libraries(torch_cpu PUBLIC ${BREAKPAD_LIB})
target_link_libraries(torch_cpu PRIVATE ${BREAKPAD_LIB})
target_compile_definitions(torch_cpu PRIVATE ADD_BREAKPAD_SIGNAL_HANDLER)
target_include_directories(torch_cpu PUBLIC ${BREAKPAD_INCLUDE_DIR}/breakpad)
target_include_directories(torch_cpu PRIVATE ${BREAKPAD_INCLUDE_DIR}/breakpad)
else()
message(STATUS "breakpad library not found")
endif()
Expand Down

0 comments on commit 95cada8

Please sign in to comment.