-
Notifications
You must be signed in to change notification settings - Fork 21.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Gradient Compression] Refactor CommHookInterface and PythonCommHook.
Pull Request resolved: #46512 1. Let CommHookInterface::processFuture be a non-virtual method, which can be shared by both Python and C++ implementations. 2. Merge 1-line PythonCommHook constructor into the header for simplicity. 3. Rename processFuture method as parseFromHookResult for readability. 4. Simplify the comments. Original PR issue: C++ DDP Communication Hook #46348 ghstack-source-id: 114558527 Differential Revision: [D24374282](https://our.internmc.facebook.com/intern/diff/D24374282/)
- Loading branch information
wayi
committed
Oct 17, 2020
1 parent
997e672
commit 99e5925
Showing
3 changed files
with
32 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters