Skip to content

Commit

Permalink
Factor out structured generation into its own subclass. (#51583)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #51583

There are no substantive changes in this PR.  The cluster of structured
helper methods is now split off into its own class.  To make sure all of
the original closure was available, I subclassed RegisterDispatchKey and
passed it all on; the only new thing closed over is the structured
functions group being processed.  I also renamed all the methods to
remove structured_ from their names as it is now redundant.

Most of the benefit is being able to remove a level of indentation
from gen_one.

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Test Plan: Imported from OSS

Reviewed By: bhosmer

Differential Revision: D26209872

Pulled By: ezyang

fbshipit-source-id: 76c11410a24968d4f3d8a2bbc9392251a7439e6e
  • Loading branch information
ezyang authored and facebook-github-bot committed Feb 4, 2021
1 parent 93c4f9f commit a626b78
Showing 1 changed file with 245 additions and 231 deletions.

0 comments on commit a626b78

Please sign in to comment.