Skip to content

Commit

Permalink
Update on "[ONNX] Support aten::scatter_reduce"
Browse files Browse the repository at this point in the history
Fixes #84260 

`reduce='mean'` is not supported, as it's not in ONNX spec (onnx/onnx#5100)

[ghstack-poisoned]
  • Loading branch information
titaiwangms committed May 25, 2023
2 parents 313e606 + 00f5e9c commit c61b247
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/onnx/test_pytorch_onnx_onnxruntime.py
Original file line number Diff line number Diff line change
Expand Up @@ -736,8 +736,8 @@ def forward(

# Optional supports None inputs
self.run_test(model, (x,))
# TODO: AssertionError: Tensor-likes are not close!
# This might be the first arg x is skipped.
# NOTE: default value is not supported on ONNX, so torch and ONNX has
# different behavior
with self.assertRaisesRegex(AssertionError, "Tensor-likes are not close!"):
self.run_test(model, (), {"y": y}, input_names=["y"])

Expand Down

0 comments on commit c61b247

Please sign in to comment.