Skip to content

Commit

Permalink
Update on "[docs] Add "See Also" blocks for torch.t and `torch.tran…
Browse files Browse the repository at this point in the history
…spose`"


**Summary**
PR 63177 added "see also" cross-references to `torch.t` and
`torch.transpose`. However, it did so in the form of simple links
preceded by the phrase "See also". A comment on the aforementioned PR
pointed out the RST has special syntax to render a "See Also" box that
is more noticeable. This commit converts the "see also" sentences for
`torch.t` and `torch.transpose` to boxes.

**Test Plan**
Continuous integration.

*Before*

<img width="931" alt="Captura de Pantalla 2021-08-18 a la(s) 10 47 21 a  m" src="https://user-images.githubusercontent.com/4392003/129948036-a92204be-7175-456e-ae25-df41333579ce.png">

*After*
<img width="881" alt="Captura de Pantalla 2021-08-18 a la(s) 12 32 42 p  m" src="https://user-images.githubusercontent.com/4392003/129960706-f508fc6d-0ea0-4fad-8213-4321399f2f5f.png">



**Fixes**
This commit fixes #56267.

[ghstack-poisoned]
  • Loading branch information
Meghan Lele committed Sep 8, 2021
2 parents cc16073 + d959b57 commit e88c5f9
Show file tree
Hide file tree
Showing 1,055 changed files with 42,642 additions and 22,159 deletions.
6 changes: 5 additions & 1 deletion .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ build --copt=-I.
build --copt=-isystem --copt bazel-out/k8-fastbuild/bin

# Configuration to disable tty features for environments like CI

build:no-tty --curses no
build:no-tty --progress_report_interval 10
build:no-tty --show_progress_rate_limit 10

# Configuration to build with GPU support
build:gpu --define=cuda=true
# define a separate build folder for faster switching between configs
build:gpu --platform_suffix=-gpu
40 changes: 8 additions & 32 deletions .circleci/cimodel/data/pytorch_build_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
("3.6", [
("important", [X(True)]),
("parallel_tbb", [X(True)]),
("parallel_native", [X(True)]),
("pure_torch", [X(True)]),
]),
]),
# TODO: bring back libtorch test
Expand Down Expand Up @@ -47,47 +45,25 @@
# ]),
]),
]),
("11.1", [
("3.8", [
("shard_test", [XImportant(True)]),
# UNCOMMENT THE BELOW TO REENABLE LIBTORCH
# ("libtorch", [
# (True, [
# ('build_only', [X(True)]),
# ]),
# ]),
]),
]),
]),
]),
("bionic", [
("clang", [
("9", [
("3.6", [
("noarch", [XImportant(True)]),
]),
]),
("9", [
("3.6", [
("xla", [XImportant(True)]),
("vulkan", [XImportant(True)]),
]),
]),
]),
("cuda", [
("10.2", [
("3.9", [
("shard_test", [XImportant(True)]),
]),
]),
]),
("rocm", [
("3.9", [
("3.6", [
('build_only', [XImportant(True)]),
]),
]),
]),
# @jithunnair-amd believes Jenkins builds are sufficient
# ("rocm", [
# ("3.9", [
# ("3.6", [
# ('build_only', [XImportant(True)]),
# ]),
# ]),
# ]),
]),
]

Expand Down
26 changes: 11 additions & 15 deletions .circleci/cimodel/data/pytorch_build_definitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def gen_docs_configs(xenial_parent_config):
HiddenConf(
"pytorch_python_doc_build",
parent_build=xenial_parent_config,
filters=gen_filter_dict(branches_list=r"/.*/",
filters=gen_filter_dict(branches_list=["master"],
tags_list=RC_PATTERN),
)
)
Expand All @@ -230,7 +230,7 @@ def gen_docs_configs(xenial_parent_config):
HiddenConf(
"pytorch_cpp_doc_build",
parent_build=xenial_parent_config,
filters=gen_filter_dict(branches_list=r"/.*/",
filters=gen_filter_dict(branches_list=["master"],
tags_list=RC_PATTERN),
)
)
Expand All @@ -241,13 +241,6 @@ def gen_docs_configs(xenial_parent_config):
branch="master",
)
)

configs.append(
HiddenConf(
"pytorch_doc_test",
parent_build=xenial_parent_config
)
)
return configs


Expand Down Expand Up @@ -396,24 +389,27 @@ def instantiate_configs(only_slow_gradcheck):
if cuda_version == "10.2" and python_version == "3.6" and not is_libtorch and not is_slow_gradcheck:
c.dependent_tests = gen_dependent_configs(c)


if (
compiler_name == "gcc"
and compiler_version == "5.4"
compiler_name != "clang"
and not rocm_version
and not is_libtorch
and not is_vulkan
and not is_pure_torch
and parallel_backend is None
and not is_noarch
and not is_slow_gradcheck
and not only_slow_gradcheck
):
bc_breaking_check = Conf(
"backward-compatibility-check",
distributed_test = Conf(
c.gen_build_name("") + "distributed",
[],
is_xla=False,
restrict_phases=["test"],
is_libtorch=False,
is_important=True,
parent_build=c,
)
c.dependent_tests.append(bc_breaking_check)
c.dependent_tests.append(distributed_test)

config_list.append(c)

Expand Down
162 changes: 41 additions & 121 deletions .circleci/config.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .circleci/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ Docker builds are now defined with `.circleci/cimodel/data/simple/docker_definit
./build.sh pytorch-linux-bionic-py3.8-gcc9 -t myimage:latest

# Set flags (see build.sh) and build image
sudo bash -c 'BREAKPAD=1 ./build.sh pytorch-linux-bionic-py3.8-gcc9 -t myimage:latest
sudo bash -c 'PROTOBUF=1 ./build.sh pytorch-linux-bionic-py3.8-gcc9 -t myimage:latest
```

0 comments on commit e88c5f9

Please sign in to comment.